Convert Apple Pay amounts using the currency's exponent - #978
Closed
Max Harrison (maxharrison) wants to merge 1 commit into
Closed
Convert Apple Pay amounts using the currency's exponent#978Max Harrison (maxharrison) wants to merge 1 commit into
Max Harrison (maxharrison) wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 81ecdb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ana-maksimovskikh
requested changes
Aug 12, 2026
| total: { | ||
| label: tx.priceLabel ?? merchant.name, | ||
| amount: { | ||
| value: calculatedTotal.toString(), |
Contributor
There was a problem hiding this comment.
Should we also apply the format here?
Contributor
|
We might have an issue with Google rejecting formatted string on their side - worth doublechecking https://developers.google.com/pay/api/web/reference/request-objects#TransactionInfo |
Max Harrison (maxharrison)
force-pushed
the
google-pay-currency-exponent
branch
2 times, most recently
from
August 18, 2026 12:37
c1b52bd to
99cc829
Compare
Contributor
Author
|
Closing this draft. We will keep the Apple Pay correction separate from the Google Pay major-release work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple Pay request builders always divided minor-unit amounts by
100, so zero-decimal currencies rendered at one hundredth of their value and three-decimal currencies at ten times their value. They now useformatTransactionAmountfor payment and recurring totals, line items, shipping options, payment-method updates, and disbursement line items, using the currency exponent supplied byIntl.NumberFormat. This corrects the documented minor-unit contract, but merchants that compensated for the old formatting must remove that workaround, so this change is held for the next major@evervault/browserrelease.Note: This PR is stacked on #977.