You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a short description about this PR.
Add links to issues, tech plans etc.
How
Describe how you've approached the problem
I've made some progress on this, but we've down prioritized finishing this to move on to more important bits as no one is asking for this currently.
Checkpoint notes:
ChatGPT wrote most of this implementation with guidance and help at various points. It seems very confused about how to send callbacks back to React so you can invoke function handlers especially.
Android
It compiles against the SDK, completely untested
Needs verifying the native interface matches the TS API
iOS
It compiles against the EvervaultPayment SDK locally
Does not support any callbacks (delegate functions)
Only supports OneTimeTransactions
Needs verifying the native interface matches the TS API
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Add a short description about this PR.
Add links to issues, tech plans etc.
How
Describe how you've approached the problem
I've made some progress on this, but we've down prioritized finishing this to move on to more important bits as no one is asking for this currently.
Checkpoint notes:
Android
iOS
EvervaultPaymentSDK to Cocoapods https://linear.app/evervault/issue/PAY-200/publish-ios-sdk-on-cocoapodshttps://linear.app/evervault/issue/PAY-37/add-googlepay-component-to-the-react-native-sdk
https://linear.app/evervault/issue/PAY-38/add-applepay-component-to-react-native-sdk