feat(env): harden env parsing - #334
Open
Mario Savarese (marsavar) wants to merge 2 commits into
Open
Conversation
The current implementation generates a single string with double-space-separated `export KEY=VALUE` commands. This assumes that both the key and the value are sane, but it is possible that they may be malformed. If that is the case, the enclave cannot boot successfully This commit ensures that the key is a POSIX complaint variable name, and that values are shell-quoted. If an env variable name is malformed, this is added to the debug logs.
Mario Savarese (marsavar)
force-pushed
the
marsavar/harden-env-parsing
branch
from
August 7, 2026 16:47
7c569f5 to
55d7e8f
Compare
Mario Savarese (marsavar)
marked this pull request as ready for review
August 7, 2026 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(env): harden env parsing
The current implementation generates a single string with double-space-separated
export KEY=VALUEcommands. This assumes that both the key and the value are sane,but it is possible that they may be malformed. If that is the case, the enclave cannot
boot successfully
This commit ensures that the key is a POSIX complaint variable name, and that values
are shell-quoted.
If an env variable name is malformed, this is added to the debug logs.
test: add e2e tests to exercise malformed variable path
Adds e2e tests.