Add MCP skill registry install support#815
Draft
evalstate wants to merge 4 commits into
Draft
Conversation
Deploying fast-agent with
|
| Latest commit: |
fb7ecba
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://690b8426.fast-agent.pages.dev |
| Branch Preview URL: | https://feat-sep2640-mcp-skill-regis.fast-agent.pages.dev |
840e486 to
37284da
Compare
Implements the first SEP-2640 Skills over MCP slice by treating capable MCP servers as install registries for skill-md entries. Adds registry discovery, installation with MCP provenance, slash-command selection, MCP status display, docs, and the tmux/asciinema demo. Co-authored-by: olaservo <olahungerford@gmail.com>
37284da to
023b657
Compare
f3b10e1 to
ce5d80f
Compare
Reset skills-repo to the commit used by main so Cloudflare can clone submodules during the docs build.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds initial SEP-2640 “Skills over MCP” support by treating connected MCP servers as installable skill registries (without exposing MCP-served skill resources directly to the model at runtime yet).
Changes:
- Implement MCP-backed skill registry discovery + installation flow (
/skills registry,/skills add) with MCP provenance metadata. - Update TUI surfaces (MCP status display, agent info, autocompletion) to reflect MCP skills/registries.
- Add documentation + demo assets for “Skills over MCP”.
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/fast_agent/ui/test_mcp_display.py | Adds coverage asserting SEP-2640 hint placement in /mcp status output. |
| tests/unit/fast_agent/ui/test_agent_info.py | New tests for MCP surface counting and child-agent summary ordering. |
| tests/unit/fast_agent/ui/test_agent_completer.py | Adds tests for MCP registry completions in /skills registry. |
| tests/unit/fast_agent/skills/test_mcp_registry.py | New tests for capability gating, registry scanning, and MCP install provenance. |
| tests/unit/fast_agent/commands/test_skills_mcp_registry_handlers.py | New tests for listing/selecting MCP registries and browsing MCP skills. |
| tests/unit/fast_agent/commands/test_command_discovery.py | Updates command usage text to mention mcp-server option. |
| src/fast_agent/ui/prompt/completer.py | Adds MCP registry completion support for /skills registry. |
| src/fast_agent/ui/prompt/agent_info.py | Refactors agent surface counts; uses MCP aggregator for MCP agents. |
| src/fast_agent/ui/mcp_display.py | Adds “Sk” capability + a SEP-2640 hint line when MCP skills are enabled. |
| src/fast_agent/skills/provenance.py | Extends skill provenance schema/formatting/parsing for MCP-installed skills. |
| src/fast_agent/skills/operations.py | Treats MCP-sourced managed skills as non-comparable for updates. |
| src/fast_agent/skills/models.py | Adds mcp to SkillSourceOrigin and MCP provenance fields. |
| src/fast_agent/skills/mcp_registry.py | New MCP registry module: capability detection, index parsing, install. |
| src/fast_agent/skills/command_support.py | Updates /skills usage help to mention MCP registry selection. |
| src/fast_agent/mcp/mcp_aggregator.py | Exposes list_mcp_skill_registries() and records mcp_skills_enabled in status. |
| src/fast_agent/commands/handlers/skills.py | Adds MCP-aware registry selection, marketplace listing, and install flow. |
| src/fast_agent/commands/handlers/mcp_runtime.py | Extends attach/reconnect summaries to optionally show skill counts. |
| src/fast_agent/commands/command_catalog.py | Updates usage string to include MCP server selection option. |
| scripts/docs_assets.py | Adds a new terminal cast scenario and tweaks env cleanup for docs demos. |
| docs/zensical.toml | Adds “Skills over MCP” doc page to MCP nav. |
| docs/social_cards/contact-sheet.html | Updates social card sheet count + adds MCP skills card entry and adjusts xAI label. |
| docs/docs/mcp/skills-over-mcp.md | New documentation page describing scope and usage. |
| docs/docs/assets/tui/skills-over-mcp.cast | New asciinema cast demonstrating MCP registry selection and install. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
556
to
+560
| partial, | ||
| configured_urls=configured_urls, | ||
| display_formatter=format_marketplace_display_url, | ||
| ) | ||
| yield from self._complete_mcp_skill_registries(partial, offset=len(configured_urls)) |
Comment on lines
+140
to
+151
| async def list_mcp_skill_registries( | ||
| aggregator: McpSkillRegistryStatusClient, server_names: Iterable[str] | ||
| ) -> list[McpSkillRegistry]: | ||
| registries: list[McpSkillRegistry] = [] | ||
| for server_name in server_names: | ||
| server_version = await _server_version(aggregator, server_name) | ||
| registry = await scan_mcp_skill_registry( | ||
| aggregator, server_name, server_version=server_version | ||
| ) | ||
| if registry is not None: | ||
| registries.append(registry) | ||
| return registries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
This PR intentionally does not expose MCP-served skill resources directly to the model. That deeper runtime work is split into the follow-up PR.
Tests
Calfskin wallet
I would not use it; I would prefer a non-animal alternative.