Skip to content
This repository was archived by the owner on Jul 19, 2026. It is now read-only.

Tighten agent harness basics - #13

Merged
haasonsaas merged 1 commit into
mainfrom
codex/basics-cleanup-20260516
May 16, 2026
Merged

Tighten agent harness basics#13
haasonsaas merged 1 commit into
mainfrom
codex/basics-cleanup-20260516

Conversation

@haasonsaas

@haasonsaas haasonsaas commented May 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Rewrite the README around the actual lightweight provider-adapter contract, optional SDK extras, and Bazel RBE workflow.
  • Make JSON Schema generation cover Literal, None, Python 3.10 union syntax, and multi-type unions without breaking older local interpreters.
  • Add validation for retry backoff, top_p, and max_output_tokens.
  • Add registry isolation and coverage for schema/config basics.
  • Correct the Bazel RBE workflow action pins and install uv on the self-hosted runner before Bazel checks.

Test plan

  • python3 -m pytest -q
  • ruff check .
  • black --check .
  • PATH=/Users/jonathanhaas/.codex-tools/bin:$PATH actionlint .github/workflows/ci.yml .github/workflows/bazel-rbe.yml
  • PATH=/Users/jonathanhaas/.codex-tools/bin:$PATH make bazel-check

@cursor

cursor Bot commented May 16, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Medium risk due to changes in JSON schema generation (now emitting anyOf/enum and handling PEP 604 unions) and stricter HarnessConfig validation, which could alter tool schemas and reject previously-accepted configs.

Overview
Tightens the harness “basics” by expanding python_type_to_json_schema to support None, Literal enums, PEP 604 unions (T | None), and multi-type unions via anyOf instead of collapsing to a single type.

Adds additional HarnessConfig validation for retry_backoff, max_output_tokens, and top_p, plus test isolation by auto-clearing the global tool registry between tests and new test coverage for the schema/validation edge cases.

Updates the Bazel RBE workflow by fixing action pins, installing uv, and adding an explicit make bazel-rbe-smoke step; the README is rewritten to match the lightweight provider-adapter/extras model and updated dev/RBE instructions.

Reviewed by Cursor Bugbot for commit 5e629e4. Bugbot is set up for automated code reviews on this repo. Configure here.

@haasonsaas
haasonsaas force-pushed the codex/basics-cleanup-20260516 branch from b18d08e to d6d078a Compare May 16, 2026 06:08
@haasonsaas
haasonsaas force-pushed the codex/basics-cleanup-20260516 branch from d6d078a to 5e629e4 Compare May 16, 2026 06:09
@haasonsaas
haasonsaas merged commit 0f1e58b into main May 16, 2026
7 checks passed
@haasonsaas
haasonsaas deleted the codex/basics-cleanup-20260516 branch May 16, 2026 06:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant