Skip to content

fix: correct verification scripts for standard GitHub tasks#252

Merged
zjwu0522 merged 5 commits into
pin-all-versionsfrom
fix/xiangyan-github-tasks
May 12, 2026
Merged

fix: correct verification scripts for standard GitHub tasks#252
zjwu0522 merged 5 commits into
pin-all-versionsfrom
fix/xiangyan-github-tasks

Conversation

@xyliugo
Copy link
Copy Markdown
Collaborator

@xyliugo xyliugo commented May 5, 2026

Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

Description of Change

Fix verification scripts for 6 GitHub tasks that had overly strict or incorrect expected answers:

  • issue_pr_commit_workflow: Check inline review comments, not just review body
  • multi_branch_commit_aggregation: Correct UTC date (2025-08-06, not 2025-08-05)
  • deployment_status_workflow: Use regex matching for markdown formatting variations
  • feature_commit_tracking: Accept both valid SHAs for CHANGELOG 1.0.65
  • claude_collaboration_analysis: Scope to main and specify case-insensitive Co-Authored-By matching
  • issue_management_workflow: Specify Epic Tasks checklist format and priority-keyword rules for test issues

Additional Information

  • Ran each verify.py locally and confirmed they pass with valid agent outputs

xyliugo and others added 4 commits April 15, 2026 22:07
…iew body

The task description asks agents to add keywords in inline review comments
(code-level comments added via add_comment_to_pending_review), but the
verification only checked the top-level review body from /pulls/{n}/reviews.
Now also fetches /pulls/{n}/comments to check inline review comment content.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Commit 82b3afb9 has a GitHub API committer date of 2025-08-06T00:12:50Z,
so the UTC date is 2025-08-06, not 2025-08-05.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…wn formatting

Use regex-based matching instead of exact string matching for rollback
plan elements, so the verifier accepts both markdown bold and plain text
formatting from different GitHub Actions bot implementations.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…acking verify

The CHANGELOG 1.0.65 feature can be identified by two valid commits:
- 94dcaca5: merge commit that brought 1.0.65 into pr/2466-QwertyJack-main
- 5faa082d: the actual commit that first added 1.0.65 to CHANGELOG.md on main

Both are reasonable interpretations of "when the changelog was updated to
include version 1.0.65", so the verify script now accepts either answer.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@xyliugo xyliugo marked this pull request as ready for review May 5, 2026 09:41
@zjwu0522 zjwu0522 merged commit 84d68e2 into pin-all-versions May 12, 2026
2 checks passed
@zjwu0522 zjwu0522 deleted the fix/xiangyan-github-tasks branch May 12, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants