🛡️ Sentinel: [HIGH] Fix missing ReadHeaderTimeout in http.Server

[euxaristia]

🚨 Severity: HIGH
💡 Vulnerability: Found multiple http.Server initializations missing the ReadHeaderTimeout configuration.
🎯 Impact: By default, Go's http.Server does not enforce a timeout for reading headers. Attackers can hold connections open by slowly sending headers, exhausting server resources and leading to a Slowloris DoS attack.
🔧 Fix: Added ReadHeaderTimeout: 10 * time.Second to all identified http.Server initializations to ensure headers are read within a reasonable timeframe.
✅ Verification: Verified by running tests (make test) and linters (make lint). Tested to ensure callback functionalities are not disrupted by the added timeout.

---

PR created automatically by Jules for task 6277087452732607165 started by @euxaristia

Summary by CodeRabbit

• Bug Fixes
  • Added a 10-second header-read timeout to OAuth callback servers.
  • Updated the OpenRouter callback flow to handle slow or incomplete requests more reliably.
  • Applied the same timeout behavior to supporting HTTP test infrastructure.
• Documentation
  • Documented timeout configuration guidance for HTTP servers and related security considerations.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0f9d6c87-f2f9-41ea-b14b-93aaa7068db5

📥 Commits

Reviewing files that changed from the base of the PR and between 91b413c and 9aa0ec9.

📒 Files selected for processing (5)

• .jules/sentinel.md
• internal/mcp/oauth.go
• internal/oauth/loopback.go
• internal/provideroauth/openrouter.go
• internal/tools/bash_tool_test.go

---

Walkthrough

The change adds a 10-second ReadHeaderTimeout to four Go HTTP servers and documents the configuration requirement in the Sentinel file. Existing callback routing and signaling remain unchanged.

Changes

HTTP timeout hardening

Layer / File(s)	Summary
Configure HTTP header read timeouts internal/oauth/loopback.go, internal/mcp/oauth.go, internal/provideroauth/openrouter.go, internal/tools/bash_tool_test.go, .jules/sentinel.md	The loopback, OAuth callback, OpenRouter callback, and test helper servers now set ReadHeaderTimeout to 10 seconds. Sentinel documentation records the timeout requirement.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• euxaristia/zero#10: Extends the same ReadHeaderTimeout fix to an additional test HTTP server.

Suggested reviewers: gnanam1990, vasanthdev2004

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely identifies the security fix for missing ReadHeaderTimeout settings in http.Server initializations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentinel-fix-readheadertimeout-6277087452732607165

---

_{Comment @coderabbitai help to get the list of available commands.}