feat: PR review comments in Changes sidebar and diff view#216
Open
eugenioenko wants to merge 1 commit into
Open
feat: PR review comments in Changes sidebar and diff view#216eugenioenko wants to merge 1 commit into
eugenioenko wants to merge 1 commit into
Conversation
…ng UI Integrate PR review comments directly into the existing Changes sidebar and diff view, matching the native editor look and feel with no new panels or overlays. Changes: - Add GitHub API functions to fetch, add general, and add inline PR comments - Extend ChangesGroup with comment data, conversation section, and comment input - Show comment count badges next to PR files with inline comments - Add expandable Conversation section in PR groups showing general comments - Render inline comments as styled blocks within the diff view between lines - Add two new theme-aware style constants (StyleCommentBg, StyleCommentAuthor) - Wire async comment fetching into the PR load flow - Add comment submission via the sidebar input with async posting - Auto-refresh comments after adding a new one - Update open diff tabs when comments are refreshed - Unit tests for comment filtering, counting, and formatting helpers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StyleCommentBg,StyleCommentAuthor) following the existing theme pipelineDesign approach
No new panels, overlays, or widgets. Comments are integrated directly into the existing Changes widget (sidebar) and DiffViewWidget (editor area), matching existing patterns:
changesItemKindvalues (itemConvoSection,itemComment,itemCommentInput) extend the virtual item listdiffDisplayRowinterleaves comment blocks with diff lines in the display row listOnAddComment,OnViewComment) follow the existing callback-driven architecturePrCommentAddResult,PrCommentsRefreshResult) use the standardPostEvent(EventInterrupt)patternTest plan
FormatCommentTime,CommentsForFile,GeneralComments,FileCommentCountsgo test ./...-- the only failure is pre-existingTestLoadNoFiles)make build)gh pr open <url>, verify conversation section appears🤖 Generated with Claude Code