feat: PR review comments hub (full-screen modal)#215
Open
eugenioenko wants to merge 2 commits into
Open
Conversation
Implement PR review comment reading and writing via a full-screen Review Hub modal dialog. Comments are fetched from GitHub and displayed organized by file, with inline review comments grouped under file headers and general comments in a separate section. Users can navigate with keyboard (j/k/arrows, n/p for sections), press Enter to jump to commented code, 'a' to add a general comment, and 'r' to reply inline. - GitHub API: FetchPRComments, AddPRComment, AddPRInlineComment - ReviewHubWidget: full-screen modal with scrollable comment list - Theme: CommentStyles with marker/user/body/file colors - Commands: pr.comments (Ctrl+K G), pr.addComment - Async fetch/post with event loop integration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
StyleCount was 55 but 4 new comment styles were added (indices 55-58), causing index-out-of-bounds panic in BuildStyleMap on startup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FetchPRComments,AddPRComment,AddPRInlineComment) that shell out togh apito fetch and post PR review commentsReviewHubWidget— a full-screen focusable overlay with keyboard-driven navigation (j/k, arrows, n/p for section jumps, PgUp/PgDn, Home/End), scrollbar, mouse support, and action shortcuts (Enter to jump to code,ato add comment,rto reply inline)StyleCommentMarker,StyleCommentUser,StyleCommentBody,StyleCommentFile) wired through the config/theme systempr.commentscommand (bound toCtrl+K G) andpr.addCommentcommand (palette only)PostEvent(EventInterrupt), and after posting a comment the hub auto-refetches to show the new commentTest plan
PRCommenttype structure (TestPRCommentType)ReviewHubWidgetconstruction, row building, rendering, keyboard nav, escape dismiss, enter navigation, add comment shortcut, section jumping, multiline comments, reply inline, modal event consumption (14 tests)formatCommentDatehelpermake buildcompiles cleanlymake test— all existing + new tests passpr.review, then useCtrl+K Gor command palette "Git: PR Comments" to open the Review Hub🤖 Generated with Claude Code