Stop DeleteSpammer from freezing the daemon while pausing a running spammer - #275
Draft
damilolaedwards wants to merge 1 commit into
Draft
Conversation
…pammer Deleting a running spammer called Pause while still holding the spammerMapMtx write lock, and Pause can block for up to 10 seconds waiting for the scenario to notice cancellation. Every other reader, including GetSpammer and GetAllSpammers, would freeze for that entire window since they all need the same lock. Release the lock around the Pause call and reacquire it afterward, mirroring the pattern already used for group deletes. Since the lock is briefly released, a concurrent delete of the same id could finish in the meantime, so recheck that the entry is still present before continuing. Added tests covering both the freeze itself and the reacquire race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
-race.