Credit child wallets when funding without a batcher - #274
Draft
damilolaedwards wants to merge 1 commit into
Draft
Conversation
The credit loop that adds confirmed funding amounts to each recipient's tracked balance keys off a map from transaction hash to the funding requests it covers, but that map was only ever built on the batcher path. Running with --without-batcher built one transaction per request just fine, but never recorded it in that map, so the credit loop found nothing for any of them. The on-chain transfer succeeded every time; spamoor's own ledger just never learned about it, so tracked balances stayed stale for the rest of the run. Each individual funding transaction is now recorded as a batch of one, so the same credit loop that already works for the batcher path covers this mode too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan