Stop leaking goroutines when multiple submissions fail together - #272
Draft
damilolaedwards wants to merge 1 commit into
Draft
Stop leaking goroutines when multiple submissions fail together#272damilolaedwards wants to merge 1 commit into
damilolaedwards wants to merge 1 commit into
Conversation
Each per-wallet batch has a size-1 error channel that the manager goroutine drains at most once before cancelling the batch and returning. A sub-goroutine that hit a hard submission failure sent its error on that channel unconditionally, which only works for the first one. Every other sub-goroutine that failed around the same time blocked forever on that send, since nothing drains the channel again once the manager has returned. That leak was worse than an idle goroutine: the blocked sub-goroutine never reached its own cleanup, so it never released its semaphore slot either. Enough of these over a long run against a target that is failing under load, which is exactly the condition this tool is built to create, would eventually exhaust the submission semaphore and stall all further sends from that wallet. The send is now best effort. The error is still recorded in the per-wallet results regardless of whether this particular send lands, so nothing is lost other than a signal that was already redundant once one sub-goroutine got through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
-race.