Skip to content

merge go-eth2-client upstream - #55

Open
pk910 wants to merge 5 commits into
masterfrom
pk910/upstream-merge
Open

merge go-eth2-client upstream#55
pk910 wants to merge 5 commits into
masterfrom
pk910/upstream-merge

Conversation

@pk910

@pk910 pk910 commented Aug 28, 2026

Copy link
Copy Markdown
Member

No description provided.

@redpandabot

This comment has been minimized.

@redpandabot redpandabot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #55 merges the go-eth2-client upstream tail: it adds compile-time interface-assertion files to http/mock/multi/testclients and updates mock's SubmitProposal (to take *api.SubmitProposalOpts) and renames SubmitBLSToExecutionChange to the plural SubmitBLSToExecutionChanges (taking a slice) to match the merged interfaces. I verified every asserted interface name exists in service.go and, via a per-package signature match (no Go toolchain available), that each asserted interface is actually satisfied by the asserted receiver types; all hold. I also confirmed no stale callers/signatures of the old methods remain. The change is self-consistent and additive; nothing to flag.


Reviewed 6 changed file(s) @ 72bf95ed — no blocking issues found.
"Production is the only environment that matters."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants