Use the Go 1.27 toolchain for development and CI - #54
Closed
barnabasbusa wants to merge 1 commit into
Closed
Conversation
|
Skipped automated review — PR is too large for a useful single-shot review.
Reviewed @ |
barnabasbusa
force-pushed
the
bbusa/go-1.27
branch
from
August 27, 2026 13:54
7654625 to
72579c0
Compare
|
Skipped automated review — PR is too large for a useful single-shot review.
Reviewed @ |
Set toolchain go1.27.0 in go.mod so the repo builds and tests with Go 1.27 when it is the main module, and move the lint/revive/test workflows to 1.27. The go directive stays at 1.25.0, so the minimum supported version for dependent modules does not change. Build the custom golangci-lint from v2.13.1 (supports Go 1.27) and add the Go version to the custom-gcl cache key so a binary built with an older Go is not reused. Go 1.27 changed the encoding/json unmarshal error text: it now names the outermost struct and includes array indices in the field path. Update the expected error strings in the affected JSON tests. Claude-Session: https://claude.ai/code/session_01E47DJeAkHBdyG1G3Ld7fzK
barnabasbusa
force-pushed
the
bbusa/go-1.27
branch
from
August 27, 2026 14:23
72579c0 to
1e72e37
Compare
|
Skipped automated review — PR is too large for a useful single-shot review.
Reviewed @ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolchain-only change: the
godirective stays at1.25.0, so the minimum Go version for dependent modules does not change.go.mod:toolchain go1.27.0— only applies when go-eth2-client is the main module (local dev, CI), not to consumerssetup-goon 1.27 for lint/revive/testv2.13.1(supports Go 1.27) and include the Go version in thecustom-gclcache key, so a cached binary built with an older Go is not reused against a 1.27 target (the Go language version used to build golangci-lint is lower than the targeted Go version)encoding/jsonunmarshal error text (it now names the outermost struct and includes array indices in the field path, e.g.Go struct field inclusionListJSON.transactions→inclusionListJSON.transactions.0). Updated the 31 expected error strings in the affected*_test.gofiles sogo test ./...passes on the toolchain the repo now builds with; no code changes.go test ./...passes on go1.27.0. Ran the custom golangci-lint v2.13.1 built with 1.27 on master and this branch: same 79 pre-existing issues, no new ones.https://claude.ai/code/session_01E47DJeAkHBdyG1G3Ld7fzK