Synchronize and reset the DVT middleware connection flag - #49
Open
damilolaedwards wants to merge 1 commit into
Open
Synchronize and reset the DVT middleware connection flag#49damilolaedwards wants to merge 1 commit into
damilolaedwards wants to merge 1 commit into
Conversation
connectedToDVTMiddleware was written from checkDVT without holding any lock, while Proposal and BlindedProposal read it unlocked to decide whether to skip the RANDAO reveal check. It was also never cleared once set, so a client that ever connected through DVT middleware kept skipping that check for the rest of its life, even after reconnecting to a plain node. Guard the flag with the existing connection mutex, add an accessor for the read sites to use, and reset the flag whenever the connection goes inactive so it gets re-evaluated fresh on every reconnect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connectedToDVTMiddleware was written from checkDVT without holding any lock, while Proposal and BlindedProposal read it unlocked to decide whether to skip the RANDAO reveal check. It was also never cleared once set, so a client that connected through DVT middleware once kept skipping that check for the rest of its life, even after reconnecting to a plain node later on.
This guards the flag with the existing connection mutex, adds an accessor for the read sites to use, and resets the flag whenever the connection goes inactive so it gets re-evaluated fresh on every reconnect.
Test plan