Skip to content

devnet-9: implement the digitalocean size override and size the buildoors #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qu0b wants to merge 1 commit into
base: master
Choose a base branch
from
Open

devnet-9: implement the digitalocean size override and size the buildoors #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion terraform/devnet-9/digitalocean.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,15 @@ locals {
(node.count > 0 ? (node.validator_end - node.validator_start) / node.count >= 128 : false)
)

# Size: explicit > supernode-based default
size = (
node.size != null ? node.size :
(node.supernode != null ? node.supernode :
can(regex("(bootnode|mev)", node.name)) ? true :
(node.count > 0 ? (node.validator_end - node.validator_start) / node.count >= 128 : false)
) ? var.digitalocean_supernode_size : var.digitalocean_fullnode_size
)

region = node.region != null ? node.region : lookup(
var.digitalocean_region_overrides,
"${node.name}-${node.start_index + i + 1}",
Expand Down Expand Up @@ -258,7 +267,7 @@ locals {
ssh_keys = [data.digitalocean_ssh_key.main.fingerprint]
region = vm.region
image = local.digitalocean_default_image
size = vm.supernode ? var.digitalocean_supernode_size : var.digitalocean_fullnode_size
size = vm.size
resize_disk = true
monitoring = true
backups = false
Expand Down
8 changes: 4 additions & 4 deletions terraform/devnet-9/nodes.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ variable "nodes" {
default = [
{ name = "bootnode", count = 4, cloud = "digitalocean" },
# Buildoor
{ name = "buildoor-prysm-ethrex", count = 1, cloud = "digitalocean", builder_start = 0 },
{ name = "buildoor-lighthouse-geth", count = 1, cloud = "digitalocean", builder_start = 1 },
{ name = "buildoor-lodestar-ethrex", count = 1, cloud = "digitalocean", builder_start = 2 },
{ name = "buildoor-teku-nethermind", count = 1, cloud = "digitalocean", builder_start = 3 },
{ name = "buildoor-prysm-ethrex", count = 1, cloud = "digitalocean", builder_start = 0, size = "s-8vcpu-32gb-640gb-intel" },

@redpandabot redpandabot Bot Sep 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Hardcoded 32 GB slug duplicates var.digitalocean_supernode_size

The four entries hardcode s-8vcpu-32gb-640gb-intel, which is exactly the default of var.digitalocean_supernode_size (digitalocean.tf:17) that sizes the other ~1000 nodes. If that variable is retuned, the buildoors silently stay on the old tier — the same silent-divergence footgun this PR is fixing. Consider a dedicated digitalocean_buildoor_size var or a try(var.digitalocean_supernode_size, ...) base instead of a literal.

{ name = "buildoor-lighthouse-geth", count = 1, cloud = "digitalocean", builder_start = 1, size = "s-8vcpu-32gb-640gb-intel" },
{ name = "buildoor-lodestar-ethrex", count = 1, cloud = "digitalocean", builder_start = 2, size = "s-8vcpu-32gb-640gb-intel" },
{ name = "buildoor-teku-nethermind", count = 1, cloud = "digitalocean", builder_start = 3, size = "s-8vcpu-32gb-640gb-intel" },

# 1000-node stress test approximating mainnet client distribution (Aug 2026).
# CL weights: lighthouse 43%, prysm 31%, teku 14%, nimbus 8%, lodestar 3%, grandine 1%.
Expand Down
Loading