Clear the candidate build marker on a failed attempt - #171
Open
damilolaedwards wants to merge 1 commit into
Open
Clear the candidate build marker on a failed attempt#171damilolaedwards wants to merge 1 commit into
damilolaedwards wants to merge 1 commit into
Conversation
executeCandidateBuild marked a (slot, parent-tuple) candidate as started before attempting the build, but never cleared that marker when the build failed - either the engine call itself or the payload transform step. A single transient error permanently blocked any retry of that candidate for the rest of the slot, including a legitimate CL-client attributes redelivery for the exact same parent, which was silently dropped instead of retried. Both failure paths now clear the marker before returning, so a later trigger for the same tuple gets a real attempt instead of being dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
executeCandidateBuild marked a (slot, parent-tuple) candidate as started
before attempting the build, but never cleared that marker when the build
failed - either the engine call itself or the payload transform step. A
single transient error permanently blocked any retry of that candidate for
the rest of the slot, including a legitimate CL-client attributes
redelivery for the exact same parent, which was silently dropped instead of
retried.
Fix
Both failure paths now clear the marker before returning, so a later
trigger for the same tuple gets a real attempt instead of being dropped.
Testing
TestExecuteCandidateBuild_RetriesAfterAFailedAttemptdrives two buildattempts for the identical (slot, parent-tuple) through a deterministic
forced failure (an unknown-fork chain stub, so the fork-version lookup
errors before any engine/beacon call is needed) and asserts both fire a
build-failed event.
Confirmed it catches the regression: reverted just the production file, the
test failed with exactly the predicted message (second attempt silently
dropped), restored the fix, test passes.
go build,go vet, andgo test -race ./pkg/...all pass (aside from apre-existing, unrelated failure in
pkg/webuicaused by the frontend notbeing built in this checkout).