Fix uint64 underflow in slot arithmetic - #92
Open
damilolaedwards wants to merge 1 commit into
Open
Conversation
Two spots subtracted slot numbers without checking for underflow. ProposerDelay compared currSlot minus the block's slot against a threshold, so a block one slot ahead of the wallclock (ordinary clock skew) underflowed to a huge number and got silently dropped instead of recorded. Empty slot detection computed slot minus one to look up the previous block, which underflows to the max uint64 at slot 0 and requests a nonsense block. Both are guarded now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two spots subtracted slot numbers without checking for underflow, both uint64.
ProposerDelay compared currSlot minus the block's slot against a threshold to skip old blocks. A block one slot ahead of the wallclock, which happens on ordinary clock skew, underflows that subtraction to a huge number and gets silently dropped from the metric instead of recorded.
Empty slot detection computed slot minus one to look up the previous block. At slot 0 that underflows to the max uint64 value and requests a nonsense block.
Test plan