Fix Genesis() silently returning nil instead of an error - #91
Open
damilolaedwards wants to merge 1 commit into
Open
Fix Genesis() silently returning nil instead of an error#91damilolaedwards wants to merge 1 commit into
damilolaedwards wants to merge 1 commit into
Conversation
Spec() and Genesis() are both cached values that may not be ready before bootstrap completes, but Spec() returned an error on unset while Genesis() returned a bare nil. A consumer checking the error the same way for both would nil deref on Genesis. Now both getters share the same contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spec() and Genesis() are both cached values that may not be ready before bootstrap completes, but Spec() returned an error on unset while Genesis() returned a bare nil. A consumer checking the error the same way for both, a reasonable assumption given the shared shape, nil derefs on Genesis instead of getting an error back.
Fix makes Genesis() share the same contract as Spec().
Test plan