Remove unguarded and unread peers field - #88
Open
damilolaedwards wants to merge 1 commit into
Open
Conversation
n.peers was written from FetchPeers without any lock, racing between the peers cron and any consumer calling FetchPeers directly. Nothing in the codebase ever read it, since FetchPeers already returns the result directly and metrics read peer counts off the published event. Removing the field removes the race entirely instead of just guarding dead state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
n.peers was written from FetchPeers without any lock, racing between the 60s peers cron and any consumer calling FetchPeers directly. Nothing in the codebase ever read it: FetchPeers already returns the result directly, and metrics read peer counts off the published event instead.
Rather than just adding a lock to guard state nothing uses, this removes the field entirely, which removes the race along with the dead state.
Test plan