Fix shared slice mutation in fork schedule builder - #85
Open
damilolaedwards wants to merge 1 commit into
Open
Conversation
ForkScheduleFromForkEpochs sorted its argument in place, which shares a backing array with whatever Spec the caller holds. Calling this read-shaped method reordered Spec.ForkEpochs out from under the caller, and raced against anything else reading that slice concurrently, such as the fork metrics job. Now it sorts a copy, matching how BlobSchedule already handles this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ForkScheduleFromForkEpochs sorted its argument in place with sort.Slice. Since a slice argument shares its backing array with the caller, calling this read-shaped, innocuously named method reorders the caller's Spec.ForkEpochs out from under it, and races against anything else reading that slice concurrently, such as the fork metrics job that runs by default.
Fix sorts a copy instead, the same way BlobSchedule.GetMaxBlobsPerBlock already does.
Test plan