Fix nil pointer panic on invalid terminal total difficulty - #83
Open
damilolaedwards wants to merge 1 commit into
Open
Fix nil pointer panic on invalid terminal total difficulty#83damilolaedwards wants to merge 1 commit into
damilolaedwards wants to merge 1 commit into
Conversation
SetString returns a nil result on parse failure, and the return value was being discarded before dereferencing it. A spec response with a non-decimal TERMINAL_TOTAL_DIFFICULTY value would crash the caller. Now it just leaves the field at its zero value when parsing fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state.NewSpec discarded the ok flag from big.Int.SetString and dereferenced the result unconditionally. SetString returns nil on any parse failure, so a spec response with a non-decimal TERMINAL_TOTAL_DIFFICULTY value (for example a hex-encoded one) crashes the caller with a nil pointer dereference.
Fix leaves the field at its zero value when parsing fails instead of dereferencing a nil result.
Test plan