Skip to content

fix: validate linked protection duration fields#1672

Open
sirakinb wants to merge 1 commit into
etherisc:developfrom
sirakinb:codex/fix-linked-entry-validation
Open

fix: validate linked protection duration fields#1672
sirakinb wants to merge 1 commit into
etherisc:developfrom
sirakinb:codex/fix-linked-entry-validation

Conversation

@sirakinb

Copy link
Copy Markdown

Fixes #238.

This tightens the linked entry-field behavior between protection duration and protection end date:

  • revalidates protected amount, duration, and end date before premium calculation
  • keeps the linked duration/end-date fields validated when one updates the other
  • applies min/max validation and helper text to the date picker
  • recalculates premium after bundles load if the protected amount was already touched

Testing:

  • git diff --check
  • npm run lint -- --file src/components/application/application_form.tsx
  • npm test -- --runInBand tests/components/application/application_form.test.tsx

@sirakinb

Copy link
Copy Markdown
Author

Note on the failing CLA check: GitGuardian has passed, and the failing job is only CLAAssistant.

This appears to be the same repository-side CLA Assistant infrastructure problem seen on the other current Etherisc PRs: the workflow is failing inside the CLA Assistant step while trying to read the private/shared signature repository, not on the application code changes. Could a maintainer please rerun/fix the CLA Assistant token or advise how you want contributor CLA handled here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Few bugs with linked entry fields

2 participants