fix: validate linked protection duration fields#1672
Open
sirakinb wants to merge 1 commit into
Open
Conversation
1 task
Author
|
Note on the failing CLA check: GitGuardian has passed, and the failing job is only This appears to be the same repository-side CLA Assistant infrastructure problem seen on the other current Etherisc PRs: the workflow is failing inside the CLA Assistant step while trying to read the private/shared signature repository, not on the application code changes. Could a maintainer please rerun/fix the CLA Assistant token or advise how you want contributor CLA handled here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #238.
This tightens the linked entry-field behavior between protection duration and protection end date:
Testing:
git diff --checknpm run lint -- --file src/components/application/application_form.tsxnpm test -- --runInBand tests/components/application/application_form.test.tsx