discv5: re-send existing WHOAREYOU challenge when handshake is in progress - #278
Open
ackintosh wants to merge 1 commit into
Open
discv5: re-send existing WHOAREYOU challenge when handshake is in progress#278ackintosh wants to merge 1 commit into
ackintosh wants to merge 1 commit into
Conversation
jxs
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec currently tells implementations to respond with a new WHOAREYOU challenge when an ordinary message packet arrives while a challenge is already in progress. This invalidates the handshake the remote end may already be computing against the earlier challenge.
go-ethereum has re-sent the existing challenge since ethereum/go-ethereum#31356. The need for a spec change was noted in ethereum/go-ethereum#31111 but never made.