-
Notifications
You must be signed in to change notification settings - Fork 294
quic.md: add initial draft of QUIC transport #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fjl
wants to merge
1
commit into
ethereum:master
Choose a base branch
from
fjl:quic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # ethp2p QUIC transport | ||
|
|
||
| This document specifies a QUIC-based protocol that nodes on the execution layer | ||
| implement to enable connectivity from browsers, and between each other. | ||
|
|
||
| ## Connection Setup | ||
|
|
||
| ### TLS Certificate | ||
|
|
||
| Implementations must generate a new, self-signed TLS certificate with a lifetime of two | ||
| weeks. If the node is to run for longer than two weeks, a new certificate must be created | ||
| and announced (see below) ahead of time. | ||
|
|
||
| Certificates should support key material for a P256-curve based key exchange. The TLS | ||
| configuration must include support for the `TLS_AES_128_GCM_SHA256` cipher suite, and may | ||
| include support for more cipher suites. | ||
|
|
||
| ### Certificate Hashes in Discovery | ||
|
|
||
| For node implementations that support QUIC, the ENR must include the SHA256 hashes of the | ||
| current certificate (and next certificate). This is to be stored in the `qh` ENR key, | ||
| which should have a size of either 32 bytes (for one certificate) or 64 bytes (for two | ||
| certificates). | ||
|
|
||
| The certificate hashes are computed as the SHA256 hash of the DER encoding of the | ||
| certificate. This feature exists primarily for compatibility with WebTransport, but | ||
| non-browser implementations should also verify the presented certificate upon connection | ||
| to an ENR. | ||
|
|
||
| ### Node ID Binding | ||
|
|
||
| Since the public key used by TLS does not match the key used for signing the ENR, fresh | ||
| connections must prove ownership of the node key that signed the ENR. To do this, the both | ||
| sides must create a binding signature over the negotiated key material of the QUIC | ||
| connection. | ||
|
|
||
| To get the key material, use a 'key exporter' with the `ENR key binding v1` label and a | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To be clear, this refers to RFC 5705, correct? |
||
| length of `32`. | ||
|
|
||
| The first message on stream zero sent by the server is the `id-proof`. | ||
|
|
||
| id-proof = "ENR-key-proof-v1" || id-signature | ||
| id-signature = sign(nodekey, tls-exported-key) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.