Update ERC-7573: Fix key parameter descriptions in ILockingContract m… - #1963
Open
mtoub wants to merge 1 commit into
Open
Update ERC-7573: Fix key parameter descriptions in ILockingContract m…#1963mtoub wants to merge 1 commit into
mtoub wants to merge 1 commit into
Conversation
Collaborator
|
The commit 78bbaaa (as a parent of c0aebc6) contains errors. |
|
Lock contract plz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Editorial fixes to the
ILockingContractmethod descriptions. No normative or semantic change.inceptTransfer: the description ofkeyEncryptedSellersaid the key "can be used by the buyer to claim the token". Both parameters of this call describe the single seller key (hash and ciphertext of the same secret), as shown by the parameter naming, the symmetric wording ofconfirmTransfer, and the reference paper's sequence diagram,inceptTransfer(H(F), E(F)). Corrected to the seller (re-)claim key.confirmTransfer: the buyer claims for the first time, so the "(re-)" prefix is removed, andkeyEncryptedBuyeris clarified as encrypting the same key hashed bykeyHashedBuyer.