Website: Fix the Auto Stagnant Bot, which has never run in this repository - #1952
Open
Cybercentry wants to merge 3 commits into
Open
Website: Fix the Auto Stagnant Bot, which has never run in this repository#1952Cybercentry wants to merge 3 commits into
Cybercentry wants to merge 3 commits into
Conversation
Collaborator
File
|
4 tasks
Mayrisass
approved these changes
Aug 22, 2026
Contributor
Author
|
Thank you, @Mayrisass! Hi @poojaranjan, could you please add this to the next Office Hour for the second review? Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Auto Stagnant Bot has never moved an ERC to Stagnant.
Why
Two faults, one hiding the other.
github.repository == 'ethereum/eips', so every run here was skipped.ethereum/EIP-Botreads a hardcodedEIPS/directory, which does not exist in this repo. From run 31285609418:The step still reports success, because
node-version: '14'turns an unhandled rejection into a warning instead of a non-zero exit. EIP-Bot was archived in January 2023, so this cannot be fixed upstream.What this does
Adds
.github/scripts/mark-stagnant-ercs.js(~280 lines, Node built-ins only, nopackage.jsonneeded) and points the workflow at it viaactions/github-script. Each run:git log(hencefetch-depth: 0)created-by-bot/1272989785, mentioning the authorsThe 2 week delay is the author's notice period, matching EIPs.
node-version: '14'is removed so failures are visible.Deliberately simpler than EIP-Bot: branch names are deterministic (
mark-erc-<n>-stagnant) and files with open pull requests are skipped, which together make duplicate pull requests impossible — so EIP-Bot's close-repeats, close-obsolete and orphan-branch-cleanup routines are not needed.Before merging
611 ERCs: 221 Draft, 63 Review. 214 have not been edited in 6+ months, the oldest untouched since the repo was split out in October 2023. The backlog is eligible all at once, so the first run opens ~214 pull requests (~850 check runs) and merges them 2 weeks later. Subsequent runs handle only that week's handful.
workflow_dispatchtakes adry-runinput, defaulting to true, which lists the affected ERCs in the job summary without changing anything. Worth running once first. Scheduled runs always run live.Happy to add a per-run cap if you would rather drain it gradually.
Testing
Against a full clone with the API mocked: 214 eligible, 213 after excluding one with an open pull request; one pull request, branch, commit and label set each; only a bot pull request older than 2 weeks is merged, by squash; a 3-day-old one is not; the commit changes exactly one line,
status: Reviewtostatus: Stagnant.Not covered: no mutating call has run against a live repository, as they need
secrets.TOKEN.