Update ERC-8056: strengthen security considerations - #1944
Draft
normanxbt wants to merge 1 commit into
Draft
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR strengthens the Security Considerations for ERC-8056 without changing its interfaces, interface IDs, or reference implementation.
It adds explicit, machine-checkable requirements for:
uint256;Motivation and discussion
The existing Security Considerations identify access-control, overflow, user-confusion, and oracle risks, but do not define enough behavior for implementations and integrators to test those properties consistently.
The linked repository pins the reviewed implementation and includes Certora specifications, configurations, deterministic Foundry tests, exact commands, source hashes, and direct Prover reports. For that pinned implementation, 21 distinct Certora rules (22 executions across five configurations) pass, and the deterministic Foundry suite passes 8/8 tests.
The formal results are implementation-scoped. They are provided as reproducible evidence for the portable security properties expressed by this specification change, not as a claim that all ERC-8056 implementations are proven.
Scope
Only
ERCS/erc-8056.mdis changed, and only its Security Considerations section is rewritten.