Feature ETP-4969: Merge block 2026-08-21 (ETP-4958, ETP-4959, ETP-4901) - #142
Merged
Conversation
LoginStep carried two independent copies of the post-authentication continuation, one per authentication branch. When the caller-owned onAuthenticated prop was introduced only the password copy was updated, so an SSO login on the invitation page persisted the session and then stopped: the caller never got its callback and the user was stranded on the login form with an unconsumed invitation token. Extract the continuation into a single exported helper that both branches call, so the two paths can no longer diverge. Add the missing onAuthenticated entry to the handleSsoProviderLogin dependency array, which otherwise captured a stale callback for any caller that memoizes config. Replace the previous source-text assert.match regression test with behavioural unit tests covering routing suppression, persistence-before- handover ordering, forwarded arguments, error propagation and the no-continuation default.
packages/etendo-go-core ran only node --test, which cannot parse .jsx. That is why the ETP-4958 regression test degraded into a source-text assert.match against LoginStep.jsx: a change detector that passes even when the code path is unreachable, and that asserts nothing about the wiring between the two authentication branches and the shared continuation helper. Add a Vitest + jsdom + Testing Library setup mirroring app-shell-core, and cover the ETP-4958 contract at component level by rendering the real LoginStep and driving each branch to a successful login: caller-owned continuation invoked with the authenticated session, no environment routing when the caller takes over, default routing preserved otherwise, and both branches producing an identical outcome. Wire the suite into .github/workflows/test.yml and make test. The workflow runs npm test per workspace, which is node --test only, so a Vitest suite without its own step would never execute. Only this package's suite is wired in; app-shell-core has the same gap but is red on the epic and is tracked separately under ETP-4961.
- isListableReport now rejects type: 'custom' the same way it already rejects type: 'document' — a custom contract is an internal NEO endpoint backing a specific page's own data needs (e.g. financial-accounts-page powers the Cuentas landing page's sidebar widgets), a real still-served endpoint that was never meant to show up as a runnable report in the catalog - Add the matching parity test case
Contributor
Copilot PR ReviewOutcome: Comment only Warnings
|
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
Contributor
Epic rollout entryFeature PR: #142 Feature ETP-4969: Merge block 2026-08-21 (ETP-4958, ETP-4959, ETP-4901) {
"number": 142,
"title": "Feature ETP-4969: Merge block 2026-08-21 (ETP-4958, ETP-4959, ETP-4901)",
"url": "https://github.com/etendosoftware/schema_forge_core/pull/142",
"author": "sebastianbarrozo",
"mergedAt": "2026-08-21T16:18:56Z",
"summaryBullets": [],
"reviewReport": {
"outcome": "Comment only",
"blockers": [],
"warnings": [
"New npm dependency added"
]
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge block
ETP-4969— one Jenkins run for the whole batch instead of one per merge.Merged into this branch (3):
feature/ETP-4958— Feature ETP-4958: Route SSO login through caller-owned continuationfeature/ETP-4959— Feature ETP-4959: Add component test runner to etendo-go-corefeature/ETP-4901— Feature ETP-4901: Exclude custom-type contracts from report listValidated locally by
ship block push(full pre-push gate), hence thelocal-validatedlabel.