Partial (?) fix for mainline issue 26 - routing maniphest tasks with …#61
Open
blades wants to merge 4 commits into
Open
Partial (?) fix for mainline issue 26 - routing maniphest tasks with …#61blades wants to merge 4 commits into
blades wants to merge 4 commits into
Conversation
…multiple projects
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
- Coverage 18.65% 18.59% -0.07%
==========================================
Files 23 23
Lines 820 823 +3
==========================================
Hits 153 153
- Misses 666 669 +3
Partials 1 1
Continue to review full report at Codecov.
|
Collaborator
|
@blades is this PR still relevant? If so can you please check the code formatting and style? And rebase on the latest |
Author
|
Unless you've fixed it yourself, then it probably is, yes. I'm unlikely to
have the time in the near future to take a look due to stuff going on irl,
but if you can wait a while I'll see what i can do. I'm not a go coder,
though, so don't really have a clue about formatting/style in go :/
…On 27 February 2018 12:55:58 pm Martin Schenck ***@***.***> wrote:
@blades is this PR still relevant? If so can you please check the code
formatting and style? And rebase on the latest `master`?
Thanks!
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#61 (comment)
|
Author
|
i've merged with your recent changes now; no conflicts apparently so that would imply you've not done any work in the affected area. |
Collaborator
|
OK, thank you. I need more time to dig into this. But you are not forgotten! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…multiple projects