ExposureFusionBayer2: Fix shadow spline duplicating the main curve - #173
Open
RealJohnGalt wants to merge 1 commit into
Open
ExposureFusionBayer2: Fix shadow spline duplicating the main curve#173RealJohnGalt wants to merge 1 commit into
RealJohnGalt wants to merge 1 commit into
Conversation
splineInterpolatorShadows was built from curveX/curveY, leaving the shadowCurveX/shadowCurveY tunables unused and the fusion's shadow response identical to the main curve. Build it from the shadow arrays. The wrong shadow lift skews the fused image's tonal balance, and AE downstream compensates for that skew globally (via the histogram average and top-0.5% whiteMax), pushing exposure up and clipping highlights. With the correct shadow curve, AE sees the intended distribution and no longer sacrifices highlight headroom, improving highlight recovery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
splineInterpolatorShadows was built from curveX/curveY, leaving the shadowCurveX/shadowCurveY tunables unused and the fusion's shadow response identical to the main curve. Build it from the shadow arrays.
The wrong shadow lift skews the fused image's tonal balance, and AE downstream compensates for that skew globally (via the histogram average and top-0.5% whiteMax), pushing exposure up and clipping highlights. With the correct shadow curve, AE sees the intended distribution and no longer sacrifices highlight headroom, improving highlight recovery.