Skip to content

[SanityCheck] Check for widget ids starting with 'wid' #4309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobrippling merged 5 commits into from
Aug 10, 2026
+3 −0
Merged

[SanityCheck] Check for widget ids starting with 'wid' #4309

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b89437e
Check for widget ids starting with 'wid'
RKBoss6 Aug 10, 2026
b3adbd7
Add clockInfo id check
RKBoss6 Aug 10, 2026
22fff7e
Fixed syntax error
RKBoss6 Aug 10, 2026
50623c8
Fix method name from hasPrefix to startsWith
RKBoss6 Aug 10, 2026
968dad3
Add ID naming exceptions for widget and clkinfo apps
RKBoss6 Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bin/sanitycheck.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ const INTERNAL_FILES_IN_APP_TYPE = { // list of app types and files they SHOULD
'textinput' : ['textinput'],
// notify?
};
const ID_NAMING_EXCEPTIONS = ["1button", "airqualityci", "banglebridge", "chimer", "f3bluemoon", "gbridge", "gpsautotime", "gpstimeserver", "grandfatherclock", "hralarm", "hwid_a_battery_widget", "lightswitch", "openseizure", "rndmclk", "sleeplogalarm", "worldclkinfo"];

function globToRegex(pattern) {
const ESCAPE = '.*+-?^${}()|[]\\';
Expand Down Expand Up @@ -250,6 +251,8 @@ apps.forEach((app,appIdx) => {
}
if (!app.description) ERROR(`App ${app.id} has no description`, {file:metadataFile});
if (!app.icon) ERROR(`App ${app.id} has no icon`, {file:metadataFile});
if (app.type == "widget" && !app.id.startsWith("wid") && !ID_NAMING_EXCEPTIONS.includes(app.id)) ERROR(`Widget app ${app.id} id does not start with 'wid'`, {file:metadataFile});
if (app.type == "clkinfo" && !app.id.startsWith("clkinfo") && !ID_NAMING_EXCEPTIONS.includes(app.id)) ERROR(`ClockInfo app ${app.id} id does not start with 'clkinfo'`, {file:metadataFile});
if (!fs.existsSync(appDir+app.icon)) ERROR(`App ${app.id} icon doesn't exist`, {file:metadataFile});
if (app.screenshots) {
if (!Array.isArray(app.screenshots)) ERROR(`App ${app.id} screenshots is not an array`, {file:metadataFile});
Expand Down
Loading