Add threshold of failed HIL jobs to prevent merge block - #1065
Open
playfulFence wants to merge 3 commits into
Open
Add threshold of failed HIL jobs to prevent merge block#1065playfulFence wants to merge 3 commits into
playfulFence wants to merge 3 commits into
Conversation
Comment on lines
+25
to
+29
| if ( | ||
| conclusion === "failure" || | ||
| conclusion === "cancelled" || | ||
| conclusion === null | ||
| ) { |
Member
There was a problem hiding this comment.
Speaking of similar issues as esp-hal for this, a timed_out job, will be treated as unexpected, so it will not count as one fail for the merge. I think, timed_out should be considered as failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1064
Mostly copied approach from esp-hal + tweak: instead of strict percentage allow a certain amount of failed HIL runs