Add esp32h4 support - #1063
Conversation
| Chip::Esp32c6 => [0x2CE0_806F].contains(&value), | ||
| Chip::Esp32c61 => [0x7211_606f].contains(&value), | ||
| Chip::Esp32h2 => [0xD7B7_3E80].contains(&value), | ||
| Chip::Esp32h4 => [0x0].contains(&value), |
There was a problem hiding this comment.
Both P4 and H4 have 0 magic number, since they rely on security info. Since H4 is matched first, fallback detection can misidentify P4 as H4 when security_info() fails. Not sure if we should cover this case
There was a problem hiding this comment.
I'd honestly just write "return" on both of them. 0 is not the real magic number IIRC, it's just that it doesn't exist and things are preferably done via security info 🤷🏼
There was a problem hiding this comment.
Agreed, esptool treats H4 and P4 as not using magic values. We should just return false for them so a failed security_info() produces an error.
|
HIL tests are failing independently from this PR, the changes here do not touch anything failure-related for any other chip (PR that intents to resolve this) |
| - CONFIG_ESPTOOLPY_FLASHSIZE_64MB=y | ||
| - CONFIG_ESPTOOLPY_FLASHSIZE="64MB" |
There was a problem hiding this comment.
Per datasheet and TRM this should be 32MB
There was a problem hiding this comment.
that tool we have is wrong, both esptool and espflash detect 8MBs of flash size on the chip which corresponds to 64KB MMU page size
I'd leave everything as is here, what I'm doing here looks the most correct.
3 participants
No description provided.