Gradle 9.x#42
Merged
Merged
Conversation
* Minimum Gradle version 8.x * Gradle 8.14.4 build * Minimum Java 17 for building
Compatibility with Gradle 9
There was a problem hiding this comment.
Pull request overview
Updates gwt-gradle-plugin for Gradle 9.x compatibility by modernizing task wiring/creation, replacing deprecated Gradle APIs, and updating the build/tooling baseline.
Changes:
- Migrate tasks/commands to use injected
ExecOperations,TaskProviderregistration, and newer Gradle APIs (e.g.,JavaPluginExtension,layout.buildDirectory,War.archiveFile). - Update plugin extension configuration methods from Groovy
Closure/ConfigureUtiltoAction. - Bump build toolchain/dependencies (Gradle wrapper, Java version in CI, Guava/Spock, publishing plugins) and document the new release.
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/de/esoco/gwt/gradle/task/GwtStopTask.java | Inject ExecOperations, disable caching by default, formatting updates |
| src/main/java/de/esoco/gwt/gradle/task/GwtSetUpTask.java | Inject ExecOperations, disable caching by default |
| src/main/java/de/esoco/gwt/gradle/task/GwtRunTask.java | Use layout.buildDirectory/archiveFile, pass ExecOperations to command |
| src/main/java/de/esoco/gwt/gradle/task/GwtDevTask.java | Replace deprecated convention APIs with extensions; pass ExecOperations to commands |
| src/main/java/de/esoco/gwt/gradle/task/GwtCompileTask.java | Inject ExecOperations, update CompileCommand ctor, adjust project dependency handling, change worker-memory detection |
| src/main/java/de/esoco/gwt/gradle/task/GwtCodeServerTask.java | Inject ExecOperations, disable caching by default, updated command construction |
| src/main/java/de/esoco/gwt/gradle/task/GwtCheckTask.java | Inject ExecOperations, migrate to JavaPluginExtension, add @Classpath to inputs |
| src/main/java/de/esoco/gwt/gradle/task/AbstractTask.java | Add ExecOperations plumbing for tasks (and caching annotation changes) |
| src/main/java/de/esoco/gwt/gradle/GwtPlugin.java | Register tasks via tasks.register instead of eager create |
| src/main/java/de/esoco/gwt/gradle/GwtLibPlugin.java | Migrate to JavaPluginExtension, refactor actions/lambdas, update build dir usage |
| src/main/java/de/esoco/gwt/gradle/extension/GwtExtension.java | Replace Closure-based configuration with Action |
| src/main/java/de/esoco/gwt/gradle/extension/DevOption.java | Use layout.buildDirectory for derived directories |
| src/main/java/de/esoco/gwt/gradle/extension/CompilerOption.java | Use layout.buildDirectory for derived directories |
| src/main/java/de/esoco/gwt/gradle/command/JettyServerCommand.java | Add ExecOperations to command execution path |
| src/main/java/de/esoco/gwt/gradle/command/CompileCommand.java | Add ExecOperations to command execution path; update build dir usage |
| src/main/java/de/esoco/gwt/gradle/command/CodeServerCommand.java | Migrate to JavaPluginExtension; add ExecOperations |
| src/main/java/de/esoco/gwt/gradle/command/AbstractCommand.java | Execute via ExecOperations.javaexec; migrate conventions to extensions |
| README.md | Add 1.3.0 release notes for Gradle 9.x compatibility |
| gradle/wrapper/gradle-wrapper.properties | Bump Gradle wrapper distribution URL |
| build.gradle | Update plugin/dependency versions; tweak compiler/javadoc settings; Gradle DSL modernizations |
| .github/workflows/build.yml | Update CI Java version to 17 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
See #43 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.