fix: support at-rules nested in @page and @font-feature-values - #543
Open
Pixel998 wants to merge 1 commit into
Open
fix: support at-rules nested in @page and @font-feature-values#543Pixel998 wants to merge 1 commit into
@page and @font-feature-values#543Pixel998 wants to merge 1 commit into
Conversation
3 tasks
DMartens
approved these changes
Aug 26, 2026
DMartens
left a comment
DMartens
left a comment
Contributor
There was a problem hiding this comment.
Changes LGTM, thanks. Leaving open for second review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
This PR fixes
no-invalid-at-rulesreporting valid CSS as unknown at-rules.Fixes #525.
The issue reports page-margin at-rules, but the same bug affects any at-rule that is only valid inside another at-rule, so this covers both families the CSS specs define:
@page(@top-left,@bottom-center, …)@font-feature-values(@styleset,@swash,@character-variant, …)Is there anything you'd like reviewers to focus on?