Skip to content

test: cover revert-rule CSS-wide keyword - #540

Draft
Pixel998 wants to merge 1 commit into
mainfrom
test/revert-rule-css-wide-keyword
Draft

test: cover revert-rule CSS-wide keyword#540
Pixel998 wants to merge 1 commit into
mainfrom
test/revert-rule-css-wide-keyword

Conversation

@Pixel998

Copy link
Copy Markdown
Contributor

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

This PR adds test coverage and documentation for the revert-rule CSS-wide keyword, which will be added to the lexer in eslint/csstree#151.

What changes did you make? (Give an overview)

  • Added revert-rule test cases to font-family-fallbacks, relative-font-units and no-invalid-properties.
  • Added revert-rule to the list of always-allowed global values in font-family-fallbacks.md and relative-font-units.md.

Related Issues

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Aug 24, 2026
@Pixel998 Pixel998 moved this from Needs Triage to Blocked in Triage Aug 24, 2026
@DMartens

Copy link
Copy Markdown
Contributor

Should we also add test case for:

  • no-invalid-properties: seems to have no CSS-wide keyword tests
  • use-baseline: some CSS-wide keywords have a baseline entry but revert-rule seems to be missing

@Pixel998

Copy link
Copy Markdown
Contributor Author

no-invalid-properties: seems to have no CSS-wide keyword tests

This PR also includes tests for no-invalid-properties.

use-baseline: some CSS-wide keywords have a baseline entry but revert-rule seems to be missing

Opened #542.

@DMartens DMartens left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks. Waiting for the csstree PR to land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Blocked

Development

Successfully merging this pull request may close these issues.

2 participants