Skip to content

update to Lean 4.29.0#4

Merged
eshelyaron merged 2 commits into
eshelyaron:mainfrom
AmosNico:bump-4.29.0
Jun 19, 2026
Merged

update to Lean 4.29.0#4
eshelyaron merged 2 commits into
eshelyaron:mainfrom
AmosNico:bump-4.29.0

Conversation

@AmosNico

@AmosNico AmosNico commented May 5, 2026

Copy link
Copy Markdown
Contributor

Update to Lean 4.29.0. Some rewrites which previously worked now failed (mostly using push_evaluate), so I had to rework some proofs.

@AmosNico AmosNico closed this May 5, 2026
@AmosNico
AmosNico deleted the bump-4.29.0 branch May 5, 2026 07:32
@AmosNico
AmosNico restored the bump-4.29.0 branch May 5, 2026 07:32
@AmosNico AmosNico reopened this May 5, 2026
@AmosNico
AmosNico force-pushed the bump-4.29.0 branch 2 times, most recently from 5b04c35 to 319e1ce Compare May 6, 2026 14:55
@AmosNico
AmosNico marked this pull request as draft May 8, 2026 11:37
@eshelyaron

Copy link
Copy Markdown
Owner

Hi @AmosNico, thanks for this!
I see you marked the PR as draft, so let me know if/when it is ready for review and if there's anything I can help with.

@AmosNico

Copy link
Copy Markdown
Contributor Author

Hi @AmosNico, thanks for this! I see you marked the PR as draft, so let me know if/when it is ready for review and if there's anything I can help with.

Hi @eshelyaron, it is more or less ready now, with the exception of one instance in Sat.lean, where I had to manually increase the number of heartbeats. set_option pp.proofs true and set_option diagnostics true suggest that the issue is that the bounds proof in denotation is becomes very large and is reduced a lot. I am not sure how to fix it, so feel free to have a look if you want.
That being said, the file still compiles (it just takes a long time), and given that it is not part of the core library, I think this could still be merged to main. I will soon add another pull request for moving the repository to the new module system, it might make more sense to fix it there.

@AmosNico
AmosNico marked this pull request as ready for review May 15, 2026 08:17
@AmosNico AmosNico mentioned this pull request May 15, 2026
@AmosNico
AmosNico marked this pull request as draft May 29, 2026 10:52
@AmosNico

Copy link
Copy Markdown
Contributor Author

All problems in Sat.lean are solved now, I added a few congruence lemmas in BDD.lean which fix the problem.

Sorry for force pushes (here and on the other pull requests), I know it makes reviewing harder. In hindsight I should have waited longer to make the pull request (or at least keep it marked as draft until it was properly ready)

@AmosNico
AmosNico marked this pull request as ready for review May 29, 2026 11:36
@AmosNico AmosNico mentioned this pull request May 29, 2026
@AmosNico
AmosNico marked this pull request as draft June 19, 2026 08:46
@eshelyaron
eshelyaron merged commit fc34710 into eshelyaron:main Jun 19, 2026
1 check passed
@eshelyaron

Copy link
Copy Markdown
Owner

Hi @AmosNico , sorry for the late response.
I've merged this PR after solving some merge conflicts due to the new Reduce implementation I pushed yesterday.
Oh, but I see you've just marked it as draft, are there additional changes we need to make here?
Thanks!

@AmosNico

Copy link
Copy Markdown
Contributor Author

Oeps I was also solving the merge conflicts, so I guess we duplicated some work. I previously forgot to update the lean version in the docbuild, so I was fixing that as well. But given that there is v4.30 anyway, I don't think it matters much, and we can keep it this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants