Add a noise-robust version of psf='gauss' for metacal#260
Open
esheldon wants to merge 5 commits into
Open
Conversation
This version is the same algorithm as Mike's original, but instead of taking looking at individual pixels, which are noisy, it makes an azimuthally averaged radial profile. The constants have also been adjusted to reduce noise amplification at mid-k
Owner
Author
|
I also factored out the the fitgauss algorithm for testing purposes |
Owner
Author
|
Owner
Author
|
Power ratio for real PSF. The new method suppresses high k power, and amplifies mid-k power less than fitgauss or original gauss 
|
Owner
Author
|
this method does something reasonable for various types of profiles 
|
beckermr
requested changes
Jun 11, 2026
beckermr
left a comment
beckermr
left a comment
Collaborator
There was a problem hiding this comment.
The code looks great.
However, this change is breaking in that the meaning of gauss when used with metadetect has changed.
Can we instead add a new name for the new algorithm? Maybe gaussprof or something?
Owner
Author
|
It breaks unit tests that expect an exact answer. Otherwise it is a strict improvement. Would it break anything other than unit tests? |
Collaborator
|
It breaks reproducibility for downstream users of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version is the same algorithm as Mike's original, but instead of looking at individual pixels, which are noisy, it makes an azimuthally averaged radial profile.
The constants have also been adjusted to reduce noise amplification at mid-k