fix: add -Wno-incompatible-pointer-types for build#107
Merged
Conversation
|
Thanks! Confirming that succeeds where installing from the main branch fails |
Refactor extra_compile_args to conditionally include flags based on platform and compilation test.
Refactor build process to always check compiler flags.
beckermr
commented
Feb 6, 2026
Add verbose flag to pip install command for better output.
Removed verbose flag from pip install command.
Add print statement for debugging extension build.
Add verbose flag to pip install command in workflow.
Use copy to avoid modifying original compile flags.
Removed debug print statement from check_flags function.
beckermr
commented
Feb 6, 2026
Contributor
Author
|
@esheldon this one is ready to go! |
esheldon
approved these changes
Feb 6, 2026
Contributor
Author
|
@esheldon I do not have push access here. You'll need to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to help fix #105.