fix(search): split FTS query terms on path separators#38
Merged
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Path-style task queries were fusing file segments into one unusable token. Split each whitespace term on non-alphanumeric boundaries, drop sub-2-char noise tokens, and add regression tests. Co-authored-by: Cursor <cursoragent@cursor.com>
solomonneas
force-pushed
the
fix/fts-path-tokenization
branch
from
July 17, 2026 21:24
2ed2d8c to
5f00da2
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
fts_queryquoted each whitespace-separated term whole, so a path-bearing query likechange src/store/sync.rsbecame one FTS token that matched nothing. Terms now split on non-alphanumeric separators (keeping_and$) into quoted tokens joined so any can match; tokens under 2 bytes drop; the existing LIKE fallback still catches degenerate queries.Why
The co-change bench (receipts in
benchmarks/context-cochange/) seeds personalized context packs withchange <path>tasks. Path-bearing seeds matched zero symbols, so packs silently fell back to tiny unpersonalized output (646/230 chars). After the fix, recall at the same 4,000-char budget went 0.239 to 0.692 (Go corpus) and 0.200 to 0.504 (Rust corpus), both ahead of an editor-integrated repo-map baseline at matched budget (0.269 / 0.236). TypeScript remains near-zero for both surfaces (import-driven co-change, recorded as the next-experiment seed).Verification
cargo fmt --check,cargo clippy --all-targets --all-features -- -D warnings,cargo test --all-features,cargo build --release(Brigade receipts). Two new tests fail against the old code. Post-fix bench rerun receipted in the results file.