Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb5292ba74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| /// Context for recursive `go` (used by actions). | ||
| pub struct ParserCtx<'a> { | ||
| pub(crate) struct ParserCtx<'a> { |
There was a problem hiding this comment.
Downstream crates can currently import ratex_parser::mhchem::ParserCtx, construct it as ParserCtx { data: data() }, and call its public go method because the enclosing mhchem module is public. Making this type pub(crate)—while also adding a required internal field—causes those consumers to stop compiling as part of an otherwise internal stack-safety change; preserve the exported API or provide a compatible migration path.
Useful? React with 👍 / 👎.
Deploying ratex with
|
| Latest commit: |
685ac0d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://50813d3f.ratex.pages.dev |
| Branch Preview URL: | https://fix-deep.ratex.pages.dev |
1 participant
fix #143 #144