apply go fix - #23201
Merged
Merged
Conversation
go fix reports three suggested fixes across the repo: a range loop in aura's debug print, a strings.Builder for concatenation in a loop, and reflect.TypeFor in place of reflect.TypeOf on a declared variable. golangci-lint has modernize enabled but bundles an older analyzer set than the toolchain, so these are not reported by make lint.
AskAlexSharov
changed the title
go fix
sudeepdino008
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go fix ./...reports exactly three suggested fixes across the repo, applied here verbatim.execution/protocol/rules/aura/aura.gofor i := 0; i < len(epochSet); i++→for i := range epochSetcommon/log/v3/log_test.go+=in a loop →strings.Buildernode/app/event/eventbus_test.goreflect.TypeOf(cb)on a declared var →reflect.TypeFor[...]()Only the aura change is production, and it is inside a
fmt.Printfblock gated onDEBUG_LOG_FROM.make lintdoes not report these even thoughmodernizeis enabled repo-wide (the only exclusion is_grpc.pb.go): golangci-lint bundles its own analyzer set, which lags the one shipped with the toolchain. Sogo fix -diff ./...is worth running periodically — it sees fixes our lint structurally cannot.