cl: harden blob backfill availability - #23198
Closed
domiwei wants to merge 1 commit into
Closed
Conversation
Member
Author
Member
Author
|
GitHub could not reopen this stale draft after its branch was rebuilt. The replacement follow-up is #23213, with the same intended 503 availability scope on the current verified branch head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blob_sidecars_by_rootresponses, verify them by identity and proof, and retry only missing sidecars503only when requested canonical blob data is still pending, while preserving available filtered data and normal empty responsesRelationship to #23138
This is a stacked follow-up to #23138. That PR remains the small fix for #22429: the exclusive
FrozenBlobs()boundary and the peer startup gate. This PR contains the broader availability contract and robustness work discovered during review, so the issue fix can be reviewed independently.The temporary base is
kewei/fix-blob-backfill-boundary; after #23138 merges, this PR can be retargeted tomainwithout changing its effective diff.Why
Reporting temporary blob unavailability through the API requires the downloader's completion state to remain accurate across legal partial network responses, fork-specific retention windows, Fulu recovery, canonical reorgs, database commit visibility, and partial persisted data. These concerns are cohesive but materially broader than the original boundary bug, so they live here rather than in #23138.
API compatibility
The Beacon API endpoint schemas do not explicitly enumerate
503for these blob endpoints. This PR intentionally uses it as an Erigon extension for temporary backfill unavailability. The response follows the shared JSON error shape (codeandmessage) and usesContent-Type: application/json.An available requested index or versioned hash remains a
200; a503is returned only when an expected requested member is missing and its canonical slot is still pending. Empty blocks, unmatched filters, side branches, frozen data, and completed or disabled backfill preserve their normal behavior.Validation
go test ./cl/phase1/network ./cl/beacon/handler ./cl/das ./cl/persistence/blob_storage ./cl/rpc ./cl/phase1/stages ./cl/phase1/forkchoice ./cmd/caplin/caplin1 -count=1make lint(complete pass: 0 issues)make erigon integrationmake test-all; this stacked branch additionally includes latest-main handler head-state changes and was revalidated with the affected package set above503