execution/state: drop the committed tier from BlockStateCache (#23140) - #23171
Draft
sudeepdino008 wants to merge 1 commit into
Draft
execution/state: drop the committed tier from BlockStateCache (#23140)#23171sudeepdino008 wants to merge 1 commit into
sudeepdino008 wants to merge 1 commit into
Conversation
sudeepdino008
force-pushed
the
sudeepdino008/bsc-drop-committed-tier
branch
from
August 11, 2026 12:39
e1297f6 to
f855b36
Compare
BlockStateCache's committed tier (committedAccounts / committedStorage) was a lazily-populated read cache of the pre-block base, seeded as a side-effect of CachedReaderV3 reads. Within a block that base (sd.mem -> StateCache -> files) is frozen -- only the block-end Flush changes it -- so the committed tier just duplicated StateCache and interfered with its LRU retention. Remove it: current-tier misses now fall through to the frozen base, which StateCache already caches. The current tier (in-block writes) and the writeLog / Flush path are unchanged. Verified against a from-genesis batched stage_exec re-execution on mainnet through the 2016 EIP-161 empty-account sweep window (block 2676607 and past
sudeepdino008
force-pushed
the
sudeepdino008/bsc-finalize-versionmap
branch
from
August 12, 2026 06:13
5dac65a to
53e4734
Compare
sudeepdino008
force-pushed
the
sudeepdino008/bsc-drop-committed-tier
branch
from
August 12, 2026 06:13
f855b36 to
908f5db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of removing/reducing dependence on
BlockStateCache(#23140). Stacked on #23149.Summary
BlockStateCachehas two tiers:CachedReaderV3reads.This removes the committed tier (
committedAccounts/committedStorage, and thePutCommitted*/GetCommitted*methods).sd.mem → StateCache → files) is frozen — only the block-endFlushchanges it — so the committed tier just duplicatedStateCacheand interfered with its LRU retention.StateCachealready caches.The current fields are unchanged.