[SharovBot] execution: make ValidateChain non-blocking to fix flaky timeout - #21431
Open
erigon-copilot[bot] wants to merge 2 commits into
Open
[SharovBot] execution: make ValidateChain non-blocking to fix flaky timeout#21431erigon-copilot[bot] wants to merge 2 commits into
erigon-copilot[bot] wants to merge 2 commits into
Conversation
ValidateChain blocked synchronously while holding the semaphore. Under -race on CI, executing high-gas blocks took long enough for the HTTP client timeout to fire, producing a non-retryable error in RetryEngine and causing "context deadline exceeded" failures. Spawn validation work in a background goroutine (using bacgroundCtx) and return ExecutionStatusBusy when the caller's context is cancelled, matching the existing UpdateForkChoice async pattern. Subsequent retries pick up the cached result from validHashes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Giulio Rebuffo <giulio.rebuffo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValidateChainblocked synchronously while holding the semaphore. Under-raceon CI, executing high-gas blocks (228M gas) took long enough for the HTTP client timeout to fire, producing a non-retryable error inRetryEngineand causingcontext deadline exceededfailures inTestInvalidReceiptHashHighMgas.bacgroundCtx) and returnExecutionStatusBusywhen the caller's context is cancelled, matching the existingUpdateForkChoiceasync pattern inforkchoice.go.validHashes, so no work is lost.Test plan
TestInvalidReceiptHashHighMgas10 consecutive times with-raceflag — all passedgo build ./...passes with no errors🤖 Generated with Claude Code