ci: align release smoke controller lifecycle

[ericlitman]

Description

Corrects the release-smoke fixture exposed by the published v2.2.1 canary. The product correctly fails a running migration when its controller is already archived; the fixture incorrectly created that controller archived. It also expected the synthetic home label after uninstall instead of the canonical ThreadBear title required by the product contract.

Manual smoke dispatches now execute the selected harness revision while the tag input selects only the immutable public release assets. Tag-triggered reusable release calls continue to execute in their caller tag context.

No product code, installer, or released asset changes.

Verification

• Corrected scripts/release-smoke.sh v2.2.1 passes against the public v2.2.1 manifest, checksums, binaries, and install command.
• Proves candidate self-test, install, migration lifecycle, title hook finalization, migration completion, prepared uninstall, canonical home cleanup, archived controller preservation, binary-last teardown, and owned-artifact absence.
• go test ./... -count=1
• go test -race ./... -count=1
• go vet ./...
• sh -n scripts/release-smoke.sh
• git diff --check
• Independent review-agent after both corrections: No findings.

The published v2.2.1 tag remains immutable; the original red smoke run is retained as an honest historical record.

[openswebot]

Open SWE Review found 1 potential issue.

Open in Web

[ericlitman]

Final verification on 8668548:

• GitHub CI: green.
• Published-release workflow dispatch 31151870465: green against immutable public v2.2.1 assets.
• Independent review-agent: No findings.
• Open SWE dashboard: 0 Bugs, No issues found; its original checkout-ref finding is marked Outdated — resolved.

The Open SWE GitHub check conclusion remained red despite that resolved dashboard state. Per the existing release decision, this upstream reconciliation mismatch is non-blocking; no review finding is being overridden.