fix: recover update checks after GitHub API failures - #142
Open
IgorArkhipov wants to merge 2 commits into
Open
Conversation
kissetfall
requested changes
Aug 12, 2026
kissetfall
left a comment
Member
There was a problem hiding this comment.
The fallback is useful, but this branch can no longer be merged through the app_update.rs conflict as written. Current main now owns both Entropy application updates and model-specific RMK firmware package lookup in the same release client.
Please rebase and port the change into that current owner with these constraints:
- keep the
/releases/latestredirect fallback specific to the Entropy application check; it provides a tag but no asset metadata and cannot replace the RMK release-list lookup, which must find the exact model/topology archive; - preserve the current trusted-URL and platform-asset selection logic, and add coverage showing that Entropy can report a version without an asset while RMK lookup does not silently fall back to an unrelated “latest” package;
- keep the macOS test-backend lock bypass as a separate focused commit (or separate PR) so it can be reviewed independently from network fallback behavior.
After the rebase, please run the current Entropy + RMK update tests and the full platform CI matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fix
Verification
cargo test --locked -- --test-threads=1— 508 passed.cargo test --locked— 508 passed.rustfmt --edition 2021 --checkandgit diff --checkpassed.