Increment version - #78
Conversation
AlbertRothman
left a comment
There was a problem hiding this comment.
Does this do anything functional or just indicate what version we are on? If it doesn't do anything functional, then I don't find the commit completely clear. I'd shorten the subject to "Increment version" and then include the details about table support in the message.
|
This particular commit for this PR right here does nothing other than increment the version. But the reason I want to increment the version is so that the table support changes can be released. |
|
Thanks for the PR changes; looking at the commit history, it doesn't look like we use bors on this repo. Thus we need to change the actual commit message and comment not just the title and first comment on github. Before merging this, I also wonder if we want to clean up the commit history for the last PR that landed multiple commits at once. I think this should be fine since it's pre-release, but maybe it's safer to just keep the extra commits. Thoughts? |
e55389a to
cdb9cdf
Compare
Changed the name of the commit message. However since the previous commits have landed on master, I think it's better to just leave them as they are, but going forward to keep the commits clean. |
Increment version after table support changes.
EREZ-678