Conversation
Owner
eraydin
commented
Apr 18, 2026
eraydin
commented
- Fix PackageProjectUrl pointing to wrong domain
- Remove empty PackageIconUrl
- Updated description and tags
- README rewrite included
- Fix PackageProjectUrl (github.io -> eraydin.net) - Remove empty PackageIconUrl - Update Description and PackageTags Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project version to 3.0.4, modifies the description to include .NET 10 support, and updates the project URL. Additionally, the package tags were refined, though it is recommended to use semi-colons as delimiters instead of commas to comply with MSBuild standards and ensure consistent parsing across NuGet tools.
| <PackageIconUrl></PackageIconUrl> | ||
| <PackageTags>EPPlus, EPPlus Core, Microsoft Excel, Excel, net10.0</PackageTags> | ||
| <PackageProjectUrl>https://eraydin.github.io/EPPlus.Core.Extensions</PackageProjectUrl> | ||
| <PackageTags>EPPlus, Excel, net10.0, extensions</PackageTags> |
There was a problem hiding this comment.
The PackageTags property in MSBuild is officially documented as a semi-colon delimited list. While NuGet.org often handles commas correctly, using semi-colons is the standard practice for MSBuild properties to ensure consistent parsing across all NuGet clients and tools.
<PackageTags>EPPlus;Excel;net10.0;extensions</PackageTags>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.